Alon Bar-Lev has posted comments on this change. Change subject: reports: added a single folder to save reports during upgrade ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/24394/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 508: self._quartzprops = None Line 509: self._users = None Line 510: self._jobs = None Line 511: self._dwhdatasource = None Line 512: self._savedReportsExists = None you do not need this, as the next will be None Line 513: self._savedReports = None Line 514: Line 515: @plugin.event( Line 516: stage=plugin.Stages.STAGE_INIT, Line 630: everything, Line 631: 'resources/saved_reports', Line 632: ) Line 633: ) Line 634: if self._savedReportsExists: no need for this as state at all.... just ask if path exists... remove variable. Line 635: self._savedReports = self._exportJs( Line 636: what='savedReports', Line 637: args=( Line 638: '--uris', '/saved_reports', Line 733: Line 734: if self._users: Line 735: self._importJs(self._users) Line 736: Line 737: if self._savedReportsExists and self._savedReports: no need for complex condition. Line 738: self._importJs(self._savedReports) Line 739: Line 740: self._importJs(self._prepareOvirtReports()) Line 741: -- To view, visit http://gerrit.ovirt.org/24394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04cdc6cbffa547d10a69ba2540e4409acb52e961 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
