Alon Bar-Lev has posted comments on this change. Change subject: reports: added a single folder to save reports during upgrade ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24394/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 612: raise RuntimeError( Line 613: _('Could not detect Jasper war folder') Line 614: ) Line 615: Line 616: self._saved-reports = self._exportJs( this is invalid variable name... please also initialize it to None at constructor. Line 617: what='saved-reports', Line 618: args=( Line 619: '--uris', '/saved_reports', Line 620: ), Line 617: what='saved-reports', Line 618: args=( Line 619: '--uris', '/saved_reports', Line 620: ), Line 621: ) if uris are supported please also convert my code of preserving the dwh data source not to export everything. Line 622: self._jobs = self._exportJs( Line 623: what='jobs', Line 624: args=( Line 625: '--report-jobs', '/', -- To view, visit http://gerrit.ovirt.org/24394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04cdc6cbffa547d10a69ba2540e4409acb52e961 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
