Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: label value title ......................................................................
Patch Set 1: Yes this is a generic fix, I noticed anything that wasn't a TextBoxLabel but was a sub class of TextBoxLabelBase didn't work. So I simply moved the code that creates the title attribute in the html up into the base class. So now anything that is a subclass of TextBoxLabelBase should automatically have their title set when they set the value. -- To view, visit http://gerrit.ovirt.org/24138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb524ba13ec9a9f37d5ddcb6b4554293d6ec23d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
