Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: iso domain nfs export fixes ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/23975/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py: Line 66: Line 67: def _nfs_export_path( Line 68: self, Line 69: conf, Line 70: path, > you didn't want to "parse" these lines. Do you now? If we do, I'd not do th why regexp? all we need is the path which is always up to first space, no? Line 71: acl=None, Line 72: old_line=None, # Used if acl is None Line 73: overwrite=False Line 74: ): Line 68: self, Line 69: conf, Line 70: path, Line 71: acl=None, Line 72: old_line=None, # Used if acl is None > Yes, the wrong thing is that you objected to parsing... ha? I objected to parsing the entire file / or the acl within the options. Line 73: overwrite=False Line 74: ): Line 75: uninstall_files = [] Line 76: exports_uninstall_group = self.environment[ Line 90: path=path, Line 91: acl=acl, Line 92: ) Line 93: ) Line 94: if overwrite: > Again, in the case of exports.d/file you didn't want to check, parse, etc. we can use the "edit" mode, but add the file (exports.d) to uninstall group at wrapper, no? Line 95: # overwrite unconditionally with a suitable comment Line 96: content = [ Line 97: '# This file is automatically generated by engine-setup.', Line 98: '# Please do not edit manually.', Line 105: if index is not None: Line 106: changes['removed'] = content[index] Line 107: content[index] = new_line Line 108: else: Line 109: content.append(new_line) > We do want to restore changes to /etc/exports. Perhaps I do not understand. hmmm if we clean up iso domain then we remove our line anyway, I know you work on some patch to leave it as-is, but I disagreed then and also now... I think we should clean up whatever we put, this means that we clean up regardless if we moved the line or not. Line 110: exports_uninstall_group.addChanges( Line 111: group='exportfs', Line 112: filename=conf, Line 113: changes=[changes], -- To view, visit http://gerrit.ovirt.org/23975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12c50b30c5df9f0da446ddbbf54c7ca73b7dd3d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
