Oved Ourfali has posted comments on this change.
Change subject: wip DON'T SUBMIT - core: USB devices
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 244: VmDeviceUtils.updateVmDevices(getVm().getStaticData());
I seems like this optimization isn't really needed here, as the function itself
doesn't do much in case there was no change in the configuration.
All we will save is a few if-s.
If okay with you, let's leave it this way, as in the near future we might
change it to work with a per-vm config.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 394: return numOfcontrollers;
in case the number of slots is 0, the function you suggested will return 1
instead of 0.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
Line 14: QXL("qxl"),
Yes.
I guess the right answer here is using USB = 23, and all the rest as -1, but
not sure about that. Waiting for an answer.
--
To view, visit http://gerrit.ovirt.org/4371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id90e976cd85f584de37a08db1981287a6554b8b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
