Eli Mesika has posted comments on this change.
Change subject: wip DON'T SUBMIT - core: USB devices
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 244: VmDeviceUtils.updateVmDevices(getVm().getStaticData());
I think that it will be cheeper to store a field in the VmHandler with the
latest config value and here just do the update if the value taken from the
configuration is different from the one cached in VmHandler.
This of course assumes that we know how to refresh configuration data without
restarting the server (Muli handled that recently IIRC)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 381: // Remote controllers
Remove
Line 394: return numOfcontrollers;
whole function can be
return math.max(numberOfSlots / SLOTS_PER_CONTROLLER, 1);
Line 579: .getVmDeviceDAO()
you can use dao here
Line 602: .getVmDeviceDAO()
you can use dao here
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
Line 14: QXL("qxl"),
types in OVF still unknown ???
--
To view, visit http://gerrit.ovirt.org/4371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id90e976cd85f584de37a08db1981287a6554b8b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
