Greg Sheremeta has posted comments on this change. Change subject: userportal: allow links in MOTD ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24006/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java: Line 169: SafeHtmlBuilder builder = new SafeHtmlBuilder(); Line 170: int urlIndex = message.indexOf("http"); //$NON-NLS-1$ Line 171: if (urlIndex != -1) { Line 172: String beforeURL = message.substring(0, urlIndex); Line 173: int afterUrlMessageIndex = message.indexOf(" ", urlIndex); //$NON-NLS-1$ +1 Line 174: int endIndex = afterUrlMessageIndex > -1 ? afterUrlMessageIndex : message.length(); Line 175: //Sanitize the URL, returns # if it is not safe. Line 176: String url = UriUtils.sanitizeUri(message.substring(urlIndex, endIndex)); Line 177: String motdAnchor = getView().getMotdAnchor(url); -- To view, visit http://gerrit.ovirt.org/24006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
