Greg Sheremeta has posted comments on this change. Change subject: userportal: allow links in MOTD ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24006/3/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java: Line 269: } Line 270: Line 271: @Override Line 272: public String getMotdAnchor(String url) { Line 273: return new Anchor(url, url, "_blank").toString(); //$NON-NLS-1$ > This method looks the same in both LoginPopupView classes, consider moving @Vojtech, where can we read more about said performance penalty? I thought it was a really good idea to let GWT create the anchor for us here. Line 274: } Line 275: Line 276: public interface Style extends CssResource { Line 277: -- To view, visit http://gerrit.ovirt.org/24006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c78c9e6d6dc9417e22c71dab66ae4507ea5c191 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
