Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: On upgrade use existing NFS export ACL ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23736/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py: Line 64: if matcher and matcher.group('path') == path: Line 65: index = i Line 66: acl = matcher.group('acl') Line 67: break Line 68: return content, index, acl > > But if you have a line, and move it, but do not have ACL, then on next up Let me explain in other words: At the beginning I thought that I just add to the 'condition=' of _misc 'ACL is not None'. This would solve the bug this change was meant to solve, but then do not move the line from exports to exports.d. If we do want to move it even if acl is none, there are two options: 1. Separate to more functions, each doing part of the work, each with its own condition=. I started doing that and decided it'll be more complex than I hoped. 2. Keep the existing _misc that does everything, just make it not write a line if acl is none. This will also turns out to be quite a big change that I'd rather not do. So instead I decided to (mostly) not touch _misc, and instead read acl from existing file(s) if it's none. Line 69: Line 70: def __init__(self, context): Line 71: super(Plugin, self).__init__(context=context) Line 72: self._enabled = True -- To view, visit http://gerrit.ovirt.org/23736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2672e1caed04d2b6b0c894eaa106949b2df83c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
