Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: On upgrade use existing NFS export ACL ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23736/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py: Line 64: if matcher and matcher.group('path') == path: Line 65: index = i Line 66: acl = matcher.group('acl') Line 67: break Line 68: return content, index, acl > Because you want to move the line to exports.d even if it's none. Don't you it is different trigger. 1. we generate a new line if we have ACL 2. we move the line if we have exports.d move 3. we generate + move if we have ACL and exports.d move two triggers 4 independent behaviours, just like in any binary counting... Line 69: Line 70: def __init__(self, context): Line 71: super(Plugin, self).__init__(context=context) Line 72: self._enabled = True -- To view, visit http://gerrit.ovirt.org/23736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2672e1caed04d2b6b0c894eaa106949b2df83c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
