Eli Mesika has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Minor comment (typo) Yair : I did not understand you question ... do you mean checking the entity if not change in the SP level ??? http://gerrit.ovirt.org/#/c/23852/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CheckedUpdate.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CheckedUpdate.java: Line 2: Line 3: Line 4: public interface CheckedUpdate<T> { Line 5: /** Line 6: * Update entity but check database before update to make sure update is neccesary neccesary=>necessary Line 7: * @param entity Line 8: * - the entity to update Line 9: */ Line 10: void updateIfNeeded(T entity); -- To view, visit http://gerrit.ovirt.org/23852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icab3ed7d251573f150d28f966d0ad2363ecc3441 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
