Eli Mesika has posted comments on this change. Change subject: core: Eliminate unneeded updates to VdsDynamic ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23852/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 272: VdsDynamic dbData = get(vdsDynamic.getId()); Line 273: if (!dbData.equals(vdsDynamic)) { Line 274: update(vdsDynamic); Line 275: } else { Line 276: log.info("Ignored an unneeded update of VdsDynamic"); > We should. Updating for no reason is a bug, and developers should see it. It is not updating for no reason it will enter here if the record that you got from DB = the one you got from VDSM and this will be in 99% of the time , so your log file will be flooded with this Therefor , it should be only in DEBUG Line 277: } Line 278: } -- To view, visit http://gerrit.ovirt.org/23852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icab3ed7d251573f150d28f966d0ad2363ecc3441 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
