Juan Hernandez has posted comments on this change. Change subject: core: Password expired should be able to contain non URL messages. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23799/4/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 25: select fn_db_rename_config_key('PowerClientAutoApprovePatterns','AutoApprovePatterns','general'); Line 26: select fn_db_rename_config_key('PowerClientAutoRegistrationDefaultVdsGroupID','AutoRegistrationDefaultVdsGroupID','general'); Line 27: select fn_db_rename_config_key('PowerClientAutoInstallCertificateOnApprove','AutoInstallCertificateOnApprove','general'); Line 28: select fn_db_rename_config_key('UseSecureConnectionWithServers', 'EncryptHostCommunication', 'general'); Line 29: select fn_db_rename_config_key('ChangePasswordUrl', 'ChangePasswordMsg', 'general'); Do we really need this? The previous change merged only to the master branch, not even to the 3.4 branch, and I believe that we don't need to support upgrade from master to stable releases. Line 30: Line 31: ------------------------------------------------------------------------------------ Line 32: -- Add configuration values section Line 33: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/23799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
