Juan Hernandez has posted comments on this change. Change subject: core: Password expired should be able to contain non URL messages. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23799/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 398: } Line 399: Line 400: private String readInteractively(String prompt, boolean isPassword) { Line 401: String value = null; Line 402: while (StringUtils.isBlank(value)) { > why? I fill it with values that are read from the STDIN... what am I missin My fault, I was thinking about "if" instead "while", sorry. Line 403: System.out.print(prompt); Line 404: if (isPassword) { Line 405: value = new String(System.console().readPassword()); Line 406: } else { -- To view, visit http://gerrit.ovirt.org/23799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
