Allon Mureinik has posted comments on this change. Change subject: core: Enable ServletUtilsTest.testCanReadFile() ......................................................................
Patch Set 1: @Alexander - this is what the Assume is used for. The assumeTrue method receives a boolean argument (in this case - !"root".equals(user)). If it's true, the test continues normally. If it's false, the test is skipped. So this way, if the test is run under root, it is skipped (in order to make sure the CI job doesn't break, as you mentioned). If it's run as a different user, the test is executed. This way the CI is not effected (the test is skipped anyway), but a local user on his machine (e.g., you or me) would get another test he can run. -- To view, visit http://gerrit.ovirt.org/23713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I754a358221d9fc370d6418a06baf08b97c25b4fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
