Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable ServletUtilsTest.testCanReadFile() ......................................................................
core: Enable ServletUtilsTest.testCanReadFile() This test was disabled in commit efa1582eafeac05b5f911dd2ce93fdfe8aa0e542 as it fails when run as root. This patch offers a cleaner way to make sure the build passes - instead of ignoring the test, Assume is used to make sure the user is not root, and if it is, silently skip the test. Using this technique we can make sure that the test is run at least some of time, and gain some extra stability. Change-Id: I754a358221d9fc370d6418a06baf08b97c25b4fa Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/23713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I754a358221d9fc370d6418a06baf08b97c25b4fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
