Liron Ar has posted comments on this change. Change subject: core: managed removal of memory volumes in negative flows ......................................................................
Patch Set 4: if we'll have command that inherit from remove vm like "RemoveVmWithExtendedLogging", the action type won't be remove vm and the logic there will be broken although it needs to be the same. I'm not somehow blocking this change, though i think that passing a parameter would be a lot better..if we have other places in the code that check parent command and not pass by parameter, it doesn't mean that we need to add more imo. you can go on with it. -- To view, visit http://gerrit.ovirt.org/23222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
