Arik Hadas has posted comments on this change. Change subject: core: managed removal of memory volumes in negative flows ......................................................................
Patch Set 4: Liron, maybe I didn't understand you well before because I agree with your last comment. That's why I didn't poll this task before, I thought we should drop this task in vdsm somehow which would have make this command a sync command, and that's why I'm changing it in this patch to be polled by RemoveMemoryVolumeCommand and not by the caller. That being said, I still need to know the parent command in order to be able to distinguish between cases where I can remove the memory only if no other snapshot use it or only if one snapshot uses it (the snapshot that is going to be removed) and it doesn't really matter if RemoveVm is doing the polling or RemoveMemoryVolumes in that case so it's better to leave it that way. -- To view, visit http://gerrit.ovirt.org/23222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
