Arik Hadas has posted comments on this change.

Change subject: frontend: support for making sub-templates
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/23327/5/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java
File 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java:

Line 20:     }
Line 21: 
Line 22:     @Inject
Line 23:     public VmMakeTemplatePopupView(EventBus eventBus, 
ApplicationResources resources, ApplicationConstants constants, 
CommonApplicationTemplates applicationTemplates) {
Line 24:         super(eventBus, resources, new 
VmMakeTemplatePopupWidget(constants, applicationTemplates), "470px", "560px"); 
//$NON-NLS-1$ //$NON-NLS-2$
> minor: I get both scrolls when expanding it...
yeah, I didn't find how to remove the horizontal scroll, do you know how?
Line 25:         ViewIdHandler.idHandler.generateAndSetIds(this);
Line 26:     }
Line 27: 


-- 
To view, visit http://gerrit.ovirt.org/23327
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35174ac6736b96e8854885a711830c93a4b79ad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to