Gilad Chaplik has posted comments on this change. Change subject: frontend: support for making sub-templates ......................................................................
Patch Set 2: Code-Review+1 (2 comments) minor comments. http://gerrit.ovirt.org/#/c/23327/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml: Line 40: <ge:StringEntityModelTextBoxEditor ui:field="commentEditor" /> Line 41: <e:ListModelTypeAheadListBoxEditor ui:field="clusterEditor" /> Line 42: <e:ListModelListBoxEditor ui:field="quotaEditor" /> Line 43: <ge:EntityModelCheckBoxEditor ui:field="isSubTemplateEditor"/> Line 44: <g:FlowPanel ui:field="subTemplateExpanderContent" visible="false" addStyleNames="{style.generalExpanderContent}"> consider controlling visibility in behind code. Line 45: <e:ListModelTypeAheadListBoxEditor ui:field="baseTemplateEditor" /> Line 46: <ge:StringEntityModelTextBoxEditor ui:field="templateVersionNameEditor" /> Line 47: </g:FlowPanel> Line 48: <g:Label ui:field="disksAllocationLabel" addStyleNames="{style.disksAllocationLabel}" /> http://gerrit.ovirt.org/#/c/23327/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java: Line 109: getModel().getHash()), Line 110: vm.getStoragePoolId()); Line 111: } Line 112: Line 113: private void updateTemplate() looks like it used in other place as well.. can you move to VmModelBehaviorBase and reuse? Line 114: { Line 115: final DataCenterWithCluster dataCenterWithCluster = Line 116: (DataCenterWithCluster) getModel().getDataCenterWithClustersList().getSelectedItem(); Line 117: StoragePool dataCenter = dataCenterWithCluster == null ? null : dataCenterWithCluster.getDataCenter(); -- To view, visit http://gerrit.ovirt.org/23327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35174ac6736b96e8854885a711830c93a4b79ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
