Sandro Bonazzola has posted comments on this change. Change subject: build: Revamp mom build system ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23400/1//COMMIT_MSG Commit Message: Line 15: other oVirt projects use. The package version is updated manually in Line 16: configure.ac and then the following commands can be used to produce Line 17: RPMS: Line 18: Line 19: rm -rf *.tar.gz why -r? Line 20: make dist Line 21: rpmbuild -ta *.tar.gz Line 22: Line 23: Change-Id: I311dcad505ba338b092c4857a4b6dc1c6180bcd9 http://gerrit.ovirt.org/#/c/23400/1/configure.ac File configure.ac: Line 9: define([VERSION_SUFFIX], []) Line 10: Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [mom-de...@googlegroups.com]) Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 13: PACKAGE_RPM_RELEASE="4$(echo VERSION_SUFFIX | sed 's/^_/./')" why 4? this is a version bump to 0.4.0, no reason for having a 4th release of it. Line 14: PACKAGE_NAME="mom" Line 15: AC_SUBST([PACKAGE_NAME]) Line 16: AC_SUBST([PACKAGE_RPM_VERSION]) Line 17: AC_SUBST([PACKAGE_RPM_RELEASE]) -- To view, visit http://gerrit.ovirt.org/23400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I311dcad505ba338b092c4857a4b6dc1c6180bcd9 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
