Alon Bar-Lev has posted comments on this change. Change subject: build: Revamp mom build system ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23400/1/mom.spec.in File mom.spec.in: Line 102: Line 103: # The use of '_pkgdocdir' conflicts with '%%doc' in some distro versions. Line 104: # Therefore, '%%doc' MUST NOT be used to include additional documentation Line 105: # files so long as this is in use. Line 106: %{_pkgdocdir}/ > Because they are to be installed in a subdirectory (examples/) so I am confused... this is going to pkgdocdir, whatever goes into examples can be installed using automake. what is missing and why needs tweaks? Line 107: Line 108: %changelog Line 109: * Fri Oct 05 2012 Adam Litke <a...@us.ibm.com> - 0.3.0-1 Line 110: - Upgrade to version 0.3.0 -- To view, visit http://gerrit.ovirt.org/23400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I311dcad505ba338b092c4857a4b6dc1c6180bcd9 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches