Frank Kobzik has posted comments on this change. Change subject: backend: sso method backend correction ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23142/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 887: Line 888: public void setSsoMethod(SsoMethod ssoMethod) { Line 889: if (ssoMethod == null) { Line 890: return; Line 891: } > I'd remove this whole thing…. in that case i'll have to remove not-null constraint in the db since engine logic cannot guarantee this constraint. and the null value will get the semantics of "default" behavior. i'll do it in this patch. Line 892: this.ssoMethod = ssoMethod; Line 893: } -- To view, visit http://gerrit.ovirt.org/23142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6e0a753748fb876a2f5c100ac1ec9ccf40aaceb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
