Frank Kobzik has posted comments on this change. Change subject: backend: sso method backend correction ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23142/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 830: Line 831: public void setSsoMethod(SsoMethod ssoMethod) { Line 832: if (ssoMethod == null) { Line 833: return; Line 834: } > why not use bean validation instead? but bean validation doesn't allow you to call this with null arg, right? instead it prevents updates to be run (canDoAction will return false in corresponding commands). Or am i wrong? this approach prevents putting the entity in inconsistent state. note that for example rest api can call this method with null value (the correspondning data is not filled in the request) and as Juan said, this must be handled on backend side... Line 835: this.ssoMethod = ssoMethod; Line 836: } -- To view, visit http://gerrit.ovirt.org/23142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6e0a753748fb876a2f5c100ac1ec9ccf40aaceb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
