Juan Hernandez has posted comments on this change. Change subject: restapi: Allow enabling/disabling SSO ......................................................................
Patch Set 9: Code-Review+1 (1 comment) Just a minor suggestion. http://gerrit.ovirt.org/#/c/21911/9/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/SsoMapperTest.java File backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/SsoMapperTest.java: Line 20: Line 21: assertNotNull(restSso); Line 22: assertNotNull(restSso.getMethods()); Line 23: assertNotNull(restSso.getMethods().getMethods()); Line 24: assertTrue(restSso.getMethods().getMethods().size() == 1); Maybe assertEquals(restSso.getMethods().size(), 1), that way if there is a failure you will get the actual length of the list in the error message. Line 25: assertEquals(org.ovirt.engine.api.model.SsoMethod.GUEST_AGENT.toString(), restSso.getMethods().getMethods().get(0)); Line 26: } Line 27: Line 28: @Test -- To view, visit http://gerrit.ovirt.org/21911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
