Frank Kobzik has posted comments on this change. Change subject: restapi: Allow enabling/disabling SSO ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/21911/7/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SsoMethod.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SsoMethod.java: Line 2: Line 3: public enum SsoMethod { Line 4: Line 5: GUEST_AGENT, Line 6: NONE; > I think that NONE shouldn't be part of this enum, because that is already r But how backend differentiate between empty <methods/> and no <methods/> at all? Currently backend has only notion of sso method, which is NONE or GUEST_AGENT which you set via setSsoMethod(...) on VM/VmStatic/VmBase. So backend doesn't know about it. If I understand this correctly, suggested behavior would result in refactoring backend. Is that right? Line 7: Line 8: public String value() { Line 9: return name().toLowerCase(); Line 10: } -- To view, visit http://gerrit.ovirt.org/21911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
