Juan Hernandez has posted comments on this change. Change subject: 6. core: Introduce new authentication interfaces ......................................................................
Patch Set 34: (1 comment) http://gerrit.ovirt.org/#/c/15596/34/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java: Line 1: package org.ovirt.engine.core.authentication; Line 2: Line 3: import java.util.List; Line 4: Line 5: import org.ovirt.engine.core.common.errors.VdcBllMessages; I still think tha the authenticator should not depend on VdcBllMessages. Line 6: Line 7: /** Line 8: * This class represents a result returned by an Authenticator Line 9: */ -- To view, visit http://gerrit.ovirt.org/15596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
