Juan Hernandez has posted comments on this change. Change subject: 6. core: Introduce new authentication interfaces ......................................................................
Patch Set 32: (2 comments) http://gerrit.ovirt.org/#/c/15596/32/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java: Line 27: public static Group map(LdapGroup entity, Group template) { Line 28: Group model = template != null ? template : new Group(); Line 29: model.setName(entity.getname()); Line 30: model.setId(entity.getid().toString()); Line 31: model.setExternalId(entity.getid().toString()); > Please remove this line, in the RESTAPI representations directory users and This is fixed in patch set 34. Line 32: if (!StringUtils.isEmpty(entity.getdomain())) { Line 33: Domain dom = new Domain(); Line 34: dom.setId(new Guid(entity.getdomain().getBytes(), true).toString()); Line 35: model.setDomain(dom); http://gerrit.ovirt.org/#/c/15596/32/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java: Line 40: @Mapping(from = LdapUser.class, to = User.class) Line 41: public static User map(LdapUser entity, User template) { Line 42: User model = template != null ? template : new User(); Line 43: model.setName(entity.getName()); Line 44: model.setExternalId(entity.getUserId().toString()); > Please remove this line. This is fixed in patch set 34. Line 45: model.setUserName(entity.getUserName()); Line 46: model.setId(entity.getUserId().toString()); Line 47: model.setLastName(entity.getSurName()); Line 48: model.setEmail(entity.getEmail()); -- To view, visit http://gerrit.ovirt.org/15596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
