Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: LANG=C for log list of packages
......................................................................
Patch Set 1: Verified+1
Works, but not sure that's what we want. Before that I had in my log:
PACKAGE: zip-3.0-1.el6.x86_64 Mon 30 Dec 2013 09:53:08
AM IST
After that, it's:
PACKAGE: zip-3.0-1.el6.x86_64 Mon Dec 30 09:53:08 2013
so it changes anyway - if someone wants to parse this, they'll have a hard time
anyway.
We might also want 'TZ=' to always output UTC.
I can see 3 options:
1. Do nothing, give up on installation timestamp
2. Merge mostly as-is (with LANG=C or LC_ALL=C as Sandro now suggested, TZ=)
3. Do something more complex with a stable, parsable output. Sadly rpm can't
accept a date format, so we can:
3.1. output timestamp, e.g. "rpm -q --queryformat '%{name} %{installtime}\n'"
zip 1388389988
3.2. same and convert using e.g. gawk or a shell loop calling date:
LANG=C TZ= rpm -q --queryformat '%{name} %{installtime}\n' zip | TZ= gawk
'{printf("%s %s\n", $1, strftime("%Y-%m-%d %H:%M:%S %Z", $2))}'
zip 2013-12-30 07:53:08 UTC
TZ=
LANG=C
rpm -q --queryformat '%{name} %{installtime}\n' zip | while read p ts; do echo
"${p}" $(date +"%Y-%m-%d %H:%M:%S %Z" -d @"${ts}"); done
(same output)
3.3. rpm -q --queryformat '%{name} %{installtime:date}\n'
zip Mon Dec 30 09:53:08 2013
All of them are too complex or too ugly or both.
--
To view, visit http://gerrit.ovirt.org/22918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
