Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: LANG=C for log list of packages ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/22918/1/packaging/bin/ovirt-engine-log-setup-event.sh.in File packaging/bin/ovirt-engine-log-setup-event.sh.in: Line 60: local distro="$(get_distro_name)" Line 61: Line 62: case "${distro}" in Line 63: redhat|centos|fedora|SuSE) Line 64: LANG=C rpm -qa --last LC_ALL=C may be better here, no? Line 65: ;; Line 66: debian|ubuntu) Line 67: dpkg -l | awk '/^ii/ {print $2, $3}' Line 68: ;; Line 63: redhat|centos|fedora|SuSE) Line 64: LANG=C rpm -qa --last Line 65: ;; Line 66: debian|ubuntu) Line 67: dpkg -l | awk '/^ii/ {print $2, $3}' LC_ALL=C here too? Line 68: ;; Line 69: *) Line 70: echo "$0: distribution ${distro} not supported" Line 71: ;; -- To view, visit http://gerrit.ovirt.org/22918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
