Omer Frenkel has posted comments on this change.

Change subject: backend: Add RebootVmCommand
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/22744/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java:

Line 13: import org.ovirt.engine.core.utils.log.LogFactory;
Line 14: 
Line 15: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 16: public class RebootVmCommand<T extends VmOperationParameterBase> 
extends VmOperationCommandBase<T> {
Line 17:     private static final Log log = 
LogFactory.getLog(RebootVmCommand.class);
looks like this is not needed anymore (and the relevant imports for it) right?
Line 18: 
Line 19:     public RebootVmCommand(T parameters) {
Line 20:         super(parameters);
Line 21:     }


http://gerrit.ovirt.org/#/c/22744/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java:

Line 109:     USER_RUN_VM_FAILURE_STATELESS_SNAPSHOT_LEFT(1001),
Line 110:     USER_RUN_VM_ON_NON_DEFAULT_VDS(152),
Line 111: 
Line 112:     USER_REBOOT_VM(157),
Line 113:     USER_FAILED_REBOOT_VM(158),
missing severity in auditLogDirector
Line 114: 
Line 115:     USER_STOP_VM(33), // User issued stopVm command
Line 116:     USER_STOP_SUSPENDED_VM(111),
Line 117:     USER_STOP_SUSPENDED_VM_FAILED(112),


-- 
To view, visit http://gerrit.ovirt.org/22744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0693943c01e204da877268c02957f3b936cf3fa2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to