Moti Asayag has posted comments on this change. Change subject: engine: Log mass network operations ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23249/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java: Line 126: private DbFacade getDbFacade() { Line 127: return DbFacade.getInstance(); Line 128: } Line 129: Line 130: public static void updateParametersSequencing(List<VdcActionParametersBase> parameters) { wouldn't you rather have this list of parameters somehow sorted ? i.e. by host id ? so any following actions will result in the same order. Line 131: for (int i = 0; i < parameters.size(); i++) { Line 132: PersistentSetupNetworksParameters setupNetworkParameters = Line 133: (PersistentSetupNetworksParameters) parameters.get(i); Line 134: setupNetworkParameters.setSequence(i + 1); http://gerrit.ovirt.org/#/c/23249/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java: Line 39: } Line 40: Line 41: @Override Line 42: protected void executeCommand() { Line 43: SetupNetworksParameters parameters = new AddNetworksByLabelParametersBuilder().buildParameters(getNic(), Please changed type to PersistentSetupNetworks Line 44: getLabel(), Line 45: getClusterNetworksByLabel()); Line 46: parameters.setShouldBeLogged(false); Line 47: -- To view, visit http://gerrit.ovirt.org/23249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie86bd5368052b4ed3bd18cff567c39daef911b31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
