Juan Hernandez has posted comments on this change. Change subject: core, tools: Supporting change password Url presentation ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23250/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java: Line 4: Line 5: /** Line 6: * This class represents a result returned by an Authenticator Line 7: */ Line 8: public abstract class AuthenticationResult<T> { I think that we don't need to make this generic, nor do you need to add the "detailedInfo" field. If the developer of an authenticator needs to store something here she/he can extend the class and add whatever is needed. The contract should be limited to the "resolveMessage" message method. or something similar. I already commented that in other patch. From my point of view the contract shouldn't depend on the VdcBllMessages class/concept, not even in the comments. Line 9: Line 10: protected T detailedInfo; Line 11: Line 12: protected AuthenticationResult(T detailedInfo) { -- To view, visit http://gerrit.ovirt.org/23250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
