Yair Zaslavsky has posted comments on this change. Change subject: core, tools: Supporting change password Url presentation ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23250/5/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 346: } Line 347: Line 348: protected String getChangePasswordUrl(CLIParser parser) throws ManageDomainsResult { Line 349: String changePasswordUrl = parser.getArg(Arguments.changePasswordUrl.name()); Line 350: if (StringUtils.isEmpty(changePasswordUrl)) { > You defined changePasswordUrl as optional in help, but this condition makes Martin - you're right, this should be accompanied with hasArg. Line 351: throw new ManageDomainsResult(ManageDomainsResultEnum.INVALID_ARGUMENT_FOR_COMMAND, Line 352: "Password change URL must not be empty"); Line 353: } Line 354: try { -- To view, visit http://gerrit.ovirt.org/23250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
