Maor Lipchuk has posted comments on this change.

Change subject: core: Use allow snapshot when Adding a disk to VM.
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 89:             ImagesHandler.setDiskAlias(getParameters().getDiskInfo(), 
getVm());
Will do, also I will move the setDiskAlias to the execute.

Line 142:     private void setAllowSnapshotForDisk() {
Fine, will change.

Line 338:         } else {
will do, changed

--
To view, visit http://gerrit.ovirt.org/4231
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to