Michael Kublin has posted comments on this change.
Change subject: core: Use allow snapshot when Adding a disk to VM.
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 89: ImagesHandler.setDiskAlias(getParameters().getDiskInfo(),
getVm());
No , if I already failed on canDoAction, I don't need to run
ImagesHandler.setDiskAlias(getParameters().getDiskInfo(), getVm()); and
setAllowSnapshotForDisk() and no any connection to GUI
Line 142: private void setAllowSnapshotForDisk() {
no, can do action should validate if value is correct, if today is not passing
anything u should use default, u will not introduce a methods which are doing
something strange
Line 338: } else {
So, for that smart people created Constructor where u can set a default value
--
To view, visit http://gerrit.ovirt.org/4231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
