Gilad Chaplik has posted comments on this change. Change subject: webadmin: adding Affinity Groups views ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/22716/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/VmsSelectionModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/VmsSelectionModel.java: Line 43: init(allVmNameMap.keySet(), usedVmNames); Line 44: } Line 45: Line 46: @Override Line 47: protected void initLineModel(KeyValueLineModel keyValueLineModel, String key) { > Actually, I think initLineModel() should be no-op too; the semantics of it Done Line 48: keyValueLineModel.getValue().setIsAvailable(false); Line 49: keyValueLineModel.getValues().setIsAvailable(false); Line 50: } Line 51: -- To view, visit http://gerrit.ovirt.org/22716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5d6f6efe2b13297b653e1622a26c7b2b44cba8 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
