Gilad Chaplik has posted comments on this change.

Change subject: webadmin: adding Affinity Groups views
......................................................................


Patch Set 8:

(3 comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/VmsSelectionModel.java
Line 98: 
Line 99:     public List<Pair<String, VM>> getAvailableKeys() {
Line 100:         Map<Guid, Pair<String, VM>> map = new HashMap<Guid, 
Pair<String, VM>>();
Line 101: 
Line 102:         if (allVmMap != null) {
sure...
Line 103:             for (VM vm : allVmMap.values()) {
Line 104:                 if (!usedVmMap.containsKey(vm.getId())) {
Line 105:                     map.put(vm.getId(), new Pair<String, 
VM>(vm.getName(), vm));
Line 106:                 }


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/list/AffinityGroupListModel.java
Line 88:     }
Line 89: 
Line 90:     protected abstract VdcQueryType getQueryType();
Line 91: 
Line 92:     protected abstract ClusterResolver getClusterResolver();
Done
Line 93: 
Line 94:     public UICommand getNewCommand() {
Line 95:         return newCommand;
Line 96:     }


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/model/AffinityGroupModel.java
Line 89:     public EntityModel<String> getName() {
Line 90:         return name;
Line 91:     }
Line 92: 
Line 93:     public void setName(EntityModel<String> name) {
Done
Line 94:         this.name = name;
Line 95:     }
Line 96: 
Line 97:     public EntityModel<String> getDescription() {


-- 
To view, visit http://gerrit.ovirt.org/22716
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5d6f6efe2b13297b653e1622a26c7b2b44cba8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to