Ori Liel has posted comments on this change. Change subject: restapi: Basic Quota API Support ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResource.java Line 44: disks.getDisks().add(disk); //TODO: add href! You're right, thanks for spotting this. This patch is a subset of a bigger patch of mine, that includes more facets of the Quota API (and contains inaccuracies as you saw). I'm dividing it into smaller patches, fixing the inaccuracies as I go along, and submitting the patches one by one. Getting a quota's disks should not be done in this patch, and should be done differently anyway, as you said. This is something that leaked by mistake into this patch. I will remove getQuotaDisks() method and the call to it, and that should address both of your comments. -- To view, visit http://gerrit.ovirt.org/4188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I609b7a9c78876ffb292f28cf55efdf48884fb29b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
