Michael Pasternak has posted comments on this change.
Change subject: restapi: Basic Quota API Support
......................................................................
Patch Set 1: (4 inline comments)
1. in rsdl_metadata_v-3.1.yaml there is no disk.quota.id
for disk creation
2. what about tests?
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 296: <!-- only one of the following entity references is set -->
white spaces
Line 2301: </xs:complexType>
white space
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResource.java
Line 41: for (DiskImage diskImage : quotaDisks) {
why not using mapper?
Line 44: disks.getDisks().add(disk); //TODO: add href!
disks should have links (htref as in todo) to vms (it should be easy as disk
has parentid)
--
To view, visit http://gerrit.ovirt.org/4188
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I609b7a9c78876ffb292f28cf55efdf48884fb29b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
