Piotr Kliczewski has posted comments on this change.
Change subject: engine: Json-rpc integration
......................................................................
Patch Set 12:
(2 comments)
The UI change was introduced to help people testing new protocol. The idea is
to introduce new protocol, make sure that all the edge cases work and migrate
to new protocol completely. As you say currently is needed only for devs.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
Line 59: /**
Line 60: * Whenever any method is executed to obtain value of response
during the first invocation it gets real response
Line 61: * from the <code>Future</code> and decompose it to object of
provided type and structure.
Line 62: */
Line 63: private synchronized void lazyGet() {
lazyEval is OK. I will change.
Line 64: if (this.responseMap.isEmpty()) {
Line 65: ResponseDecomposer decomposer;
Line 66: try {
Line 67: decomposer = new
ResponseDecomposer(this.response.get());
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
Line 51: import org.ovirt.vdsm.jsonrpc.client.JsonRpcClient;
Line 52: import org.ovirt.vdsm.jsonrpc.client.JsonRpcRequest;
Line 53: import org.ovirt.vdsm.jsonrpc.client.RequestBuilder;
Line 54:
Line 55: public class JsonRpcVdsServer implements IVdsServer {
Done
Line 56:
Line 57: private final JsonRpcClient client;
Line 58:
Line 59: public JsonRpcVdsServer(JsonRpcClient client) {
--
To view, visit http://gerrit.ovirt.org/20926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
