Yair Zaslavsky has posted comments on this change.
Change subject: engine: Json-rpc integration
......................................................................
Patch Set 12:
(2 comments)
Sorry for the somewhat "heretic" and "late in the game" question - but why do
we want to expose the transport selection at UI?
Why not having it configurable, and have engine-config set the transport type?
Is it because we want a granularity at host level to select the transport type?
Will someone (besides developers ...) be interested in having such a thing? if
this is an "older version host" we will of course use xml-rpc, I'm asking for
hosts that support this change.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
Line 59: /**
Line 60: * Whenever any method is executed to obtain value of response
during the first invocation it gets real response
Line 61: * from the <code>Future</code> and decompose it to object of
provided type and structure.
Line 62: */
Line 63: private synchronized void lazyGet() {
Perhaps the name of the method is a bit misleading.
When I first saw it I thought it has to do with "get" of map... but it being
used as written in the comment in all the map methods.
Maybe lazyEval? or something like that?
Line 64: if (this.responseMap.isEmpty()) {
Line 65: ResponseDecomposer decomposer;
Line 66: try {
Line 67: decomposer = new
ResponseDecomposer(this.response.get());
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
Line 51: import org.ovirt.vdsm.jsonrpc.client.JsonRpcClient;
Line 52: import org.ovirt.vdsm.jsonrpc.client.JsonRpcRequest;
Line 53: import org.ovirt.vdsm.jsonrpc.client.RequestBuilder;
Line 54:
Line 55: public class JsonRpcVdsServer implements IVdsServer {
Please add a comment on what this class is for...
Line 56:
Line 57: private final JsonRpcClient client;
Line 58:
Line 59: public JsonRpcVdsServer(JsonRpcClient client) {
--
To view, visit http://gerrit.ovirt.org/20926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
