Kobi Ianko has posted comments on this change. Change subject: engine: HA VM Reservation feature ......................................................................
Patch Set 6: (4 comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java Line 172: Line 173: Pair<Guid, Pair<Integer, Integer>> outerUnutilizedCpuRamPair = Line 174: new Pair<>(host.getId(), innerUnutilizedCpuRamPair); Line 175: outerUnutilizedCpuRamPair.setFirst(host.getId()); Line 176: outerUnutilizedCpuRamPair.setSecond(innerUnutilizedCpuRamPair); right, done. Line 177: Line 178: hostsUnutilizedResources.add(outerUnutilizedCpuRamPair); Line 179: } Line 180: return hostsUnutilizedResources; .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java Line 22: import org.ovirt.engine.core.utils.linq.Predicate; Line 23: Line 24: /** Line 25: * This balancing policy, is for use in cases the user selected HA Reservation for its Cluster. The basic methodology Line 26: * is: 1. get the optimal HA VMs for each VM assuming evenly spreaded across the cluster 2. calc the overUtiliaze as Done Line 27: * (1)*user configured threshold in percent. 3. randomly choose a VM from a busy host to move to another more available Line 28: * host. Line 29: */ Line 30: public class HaReservationBalancePolicyUnit extends PolicyUnitImpl { .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 838: USER_UPDATED_MOM_POLICIES(10200), Line 839: USER_FAILED_TO_UPDATE_MOM_POLICIES(10201), Line 840: Line 841: // HA Reservation Line 842: CLUSTER_ALERT_HA_RESERVATION(10202, AuditLogTimeInterval.HOUR.getValue()); Done Line 843: Line 844: private int intValue; Line 845: // indicates time interval in seconds on which identical events from same instance are suppressed. Line 846: private int eventFloodRate; .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java Line 14: */ Line 15: static { Line 16: // VDC Line 17: AddEventNotificationEntry(EventNotificationEntity.Engine, AuditLogType.VDC_STOP); Line 18: AddEventNotificationEntry(EventNotificationEntity.Engine, AuditLogType.CLUSTER_ALERT_HA_RESERVATION); Done Line 19: // VDS Line 20: AddEventNotificationEntry(EventNotificationEntity.Host, AuditLogType.VDS_FAILURE); Line 21: AddEventNotificationEntry(EventNotificationEntity.Host, AuditLogType.USER_VDS_MAINTENANCE); Line 22: AddEventNotificationEntry(EventNotificationEntity.Host, AuditLogType.USER_VDS_MAINTENANCE_MIGRATION_FAILED); -- To view, visit http://gerrit.ovirt.org/22929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44e698e58ff5e4a0b74249d3fe3cf4acf042c324 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches