Kobi Ianko has posted comments on this change.

Change subject: engine: HA VM Reservation feature
......................................................................


Patch Set 5:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java
Line 158:             }
Line 159:             innerUnutilizedCpuRamPair.setFirst(hostFreeCpu);
Line 160: 
Line 161:             int hostFreeMem = 0;
Line 162:             if (host.getPhysicalMemMb() != null && 
host.getUsageMemPercent() != null)
changed to vds.getMaxSchedulingMemory()
Line 163:             {
Line 164:                 int usedMem = (int) 
Math.round(host.getPhysicalMemMb() * (host.getUsageMemPercent() / 100.0));
Line 165:                 hostFreeMem = host.getPhysicalMemMb() - usedMem;
Line 166:             }


....................................................
File packaging/dbscripts/upgrade/03_04_0400_add_ha_reservation_weight_module.sql
Line 11: INSERT INTO cluster_policy_units 
(cluster_policy_id,policy_unit_id,filter_sequence,factor) values 
('b4ed2332-a7ac-4d5f-9596-99a439cb2812','7f262d70-6cac-11e3-981f-0800200c9a66',0,1);
Line 12: 
Line 13: INSERT INTO cluster_policy_units 
(cluster_policy_id,policy_unit_id,filter_sequence,factor) values 
('20d25257-b4bd-4589-92a6-c4c5c5d3fd1a','93431200-6d7e-11e3-981f-0800200c9a66',0,1);
Line 14: INSERT INTO cluster_policy_units 
(cluster_policy_id,policy_unit_id,filter_sequence,factor) values 
('5a2b0939-7d46-4b73-a469-e9c2c7fc6a53','93431200-6d7e-11e3-981f-0800200c9a66',0,1);
Line 15: INSERT INTO cluster_policy_units 
(cluster_policy_id,policy_unit_id,filter_sequence,factor) values 
('b4ed2332-a7ac-4d5f-9596-99a439cb2812','93431200-6d7e-11e3-981f-0800200c9a66',0,1);
balancing has no use for the factor value, will leave it as the rest of the 
balancing method (1)


-- 
To view, visit http://gerrit.ovirt.org/22929
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44e698e58ff5e4a0b74249d3fe3cf4acf042c324
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to