Maor Lipchuk has posted comments on this change.

Change subject: core: support for partial snapshot creation
......................................................................


Patch Set 6:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 706:     public static void updateAllDiskImageSnapshotsStatus(Guid diskId, 
ImageStatus status) {
Line 707:         
DbFacade.getInstance().getImageDao().updateStatusOfImagesByImageGroupId(diskId, 
status);
Line 708:     }
Line 709: 
Line 710:     public static DiskImage getDiskImageById(Guid id, 
Iterable<DiskImage> diskImages) {
Could be private?
Line 711:         for (DiskImage diskImage : diskImages) {
Line 712:             if (diskImage.getId().equals(id)) {
Line 713:                 return diskImage;
Line 714:             }


-- 
To view, visit http://gerrit.ovirt.org/22775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb7cb389229219bbb0212e3ee58cc45c39727c75
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to