Maor Lipchuk has posted comments on this change.
Change subject: core: support for partial snapshot creation
......................................................................
Patch Set 5:
(2 comments)
partial reviewed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 100: * @return list of disks to be snapshot.
Line 101: */
Line 102: protected List<DiskImage> getDisksList() {
Line 103: if (cachedSelectedActiveDisks == null) {
Line 104: // Get disks from the specified parameters or according
to the VM
probably worth to extend this code block to another nethod
Line 105: if (getParameters().getDisks() == null) {
Line 106: cachedSelectedActiveDisks = getDiskImagesForVm();
Line 107: }
Line 108: else {
Line 111:
Line 112: // Get selected images from 'DiskImagesForVm' to
ensure disks entities integrity
Line 113: // (i.e. only images' IDs are relevant).
Line 114: for (DiskImage image : getParameters().getDisks()) {
Line 115:
selectedImages.add(ImagesHandler.getDiskImageById(image.getId(), imagesForVm));
you can add null to the list if there is no match
Line 116: }
Line 117:
Line 118: cachedSelectedActiveDisks = selectedImages;
Line 119: }
--
To view, visit http://gerrit.ovirt.org/22775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb7cb389229219bbb0212e3ee58cc45c39727c75
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
