Roy Golan has posted comments on this change. Change subject: webadmin, core: Prevent arch mismatches in the FE ......................................................................
Patch Set 10: (1 comment) .................................................... File packaging/dbscripts/vds_groups_sp.sql Line 204: AS $procedure$ Line 205: BEGIN Line 206: RETURN QUERY SELECT vds_groups_view.* Line 207: FROM vds_groups_view Line 208: WHERE vds_group_id = v_vds_group_id AND NOT EXISTS(SELECT 1 FROM vms WHERE vds_group_id = v_vds_group_id) AND NOT EXISTS(SELECT 1 FROM vds_static WHERE vds_group_id = v_vds_group_id); just return a boolean for the existence of the cluster. also select on vds_group and not the vds_group_view since we don't need to joins. Line 209: END; $procedure$ Line 210: LANGUAGE plpgsql; Line 211: Line 212: -- To view, visit http://gerrit.ovirt.org/19132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0033c399061108c4495029ae2bca3f62e75fac68 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
