Roy Golan has posted comments on this change. Change subject: webadmin, core: Prevent arch mismatches in the FE ......................................................................
Patch Set 9: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsClusterEmptyQuery.java Line 21: if (cluster.getArchitecture() == ArchitectureType.undefined) { Line 22: getQueryReturnValue().setReturnValue(true); Line 23: return; Line 24: } Line 25: combine these 2 in single stored procedure under VdsGroupDao Line 26: List<VdsStatic> allVdsForVdsGroup = getDbFacade().getVdsStaticDao().getAllForVdsGroup(cluster.getId()); Line 27: Line 28: List<VM> allVmsForVdsGroup = getDbFacade().getVmDao().getAllForVdsGroup(cluster.getId()); Line 29: -- To view, visit http://gerrit.ovirt.org/19132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0033c399061108c4495029ae2bca3f62e75fac68 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches