Martin Peřina has posted comments on this change.
Change subject: tools: Adds validate only argument to notifier
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
Line 61: prop.validate();
Line 62: } catch (Exception ex) {
Line 63: log.error("Failed to parse configuration.", ex);
Line 64: // print error also to stderr to be seen in console during
service startup
Line 65: System.err.println(ex.getMessage());
The error is already logged in notifier.log, purpose of printing it into stderr
is only to show error in systemctl status. Why should I then send it also to
stdout?
Line 66: System.exit(1);
Line 67: }
Line 68:
Line 69: if (args != null && args.length > 0 &&
ARG_VALIDATE.equals(args[0])) {
--
To view, visit http://gerrit.ovirt.org/22628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d95f2f4225652d47732c12e5e0716b7f625bbe3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
