Martin Peřina has posted comments on this change.
Change subject: tools: Adds validate only argument to notifier
......................................................................
Patch Set 1:
(2 comments)
Mooli: there's no easy way how to communicate between java process and python
process since Java process is executed with its std(in/out/err) redirected to
be able to run as a daemon. So the easiest solution is to execute java process
twice: first with validate argument as standard process and check its exit code
and if validation is OK, then execute it again as a "daemon".
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
Line 29:
Line 30: /**
Line 31: * Command line argument, that tells Notifier to validate
properties only (it exits after validation)
Line 32: */
Line 33: private static final String ARG_VALIDATE = "validate";
IMHO validate is descriptive enough. And it should be hidden parameter, that's
used only in ovirt-engine-notifier.py service
Line 34:
Line 35: /**
Line 36: * Initializes logging configuration
Line 37: */
Line 49: }
Line 50:
Line 51: /**
Line 52: * @param args
Line 53: * [0] configuration file absolute path
I will fix this
Line 54: */
Line 55: public static void main(String[] args) {
Line 56: NotificationProperties prop = null;
Line 57: initLogging();
--
To view, visit http://gerrit.ovirt.org/22628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d95f2f4225652d47732c12e5e0716b7f625bbe3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
